Ensure tab state is torn down on window close #3364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @graeme, I'm a bit confused by this change. I'm adding a bit of context around this issue to explain why.
Are you sure this is resolving the reported issue? I could not reproduce / validate the original issue through the proposed testing steps. |
diegoreymendez
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
I've managed to reproduce the issue. The trick (which I missed) is to not have any other browser window open and just open a single window to play the audio on.
I could repro the issue in main but not here, so I'm approving.
I do think this should be targetting at least the internal branch, though. Please consider retargetting.
PS: it's still unclear to me why this is fixing a retain cycle, but I'll look at that separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201048563534612/1208463834186044/f
Description:
For some weeks we've had reports about music playing after a browser window playing music is closed. Turns out an indirect reference to the WebView was being held through the
ActiveDomainPublisherintroduced during #3076. I've made an attempt at fixing this, but lemme know if there's a better way.Steps to test this PR:
4. Music should stop playing
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation